97harsh commented on code in PR #14964:
URL: https://github.com/apache/iceberg/pull/14964#discussion_r2667808066
##########
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java:
##########
@@ -60,10 +61,20 @@ public RewriteDataFilesCommitManager(
long startingSnapshotId,
boolean useStartingSequenceNumber,
Map<String, String> snapshotProperties) {
+ this(table, startingSnapshotId, useStartingSequenceNumber,
snapshotProperties, null);
Review Comment:
I think it makes sense to use `null` to delegate to `SnapshotProducer`'s
default behavior rather than explicitly setting "main".
This avoids imposing an opinion - if the default branch behavior changes in
the future, this will automatically follow. The null check pattern is also
consistent with how branch handling works elsewhere in the codebase (see
SnapshotUtil methods that treat null as "use default").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
