nastra commented on code in PR #14921:
URL: https://github.com/apache/iceberg/pull/14921#discussion_r2668035317
##########
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##########
@@ -161,4 +162,10 @@ default ExpireSnapshots cleanExpiredMetadata(boolean
clean) {
throw new UnsupportedOperationException(
this.getClass().getName() + " doesn't implement cleanExpiredMetadata");
}
+
+ /** Report metrics about the ExpireSnapshots operation to the provided
reporter */
+ default ExpireSnapshots metricsReporter(MetricsReporter reporter) {
Review Comment:
for `SnapshotProducer` we defined a protected method so that this doesn't
have to be exposed in general APIs:
https://github.com/apache/iceberg/blob/026ec35b7969539b535af03944fae53d059cd233/core/src/main/java/org/apache/iceberg/SnapshotProducer.java#L191-L194
We might want to do the same in `RemoveSnapshots`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
