zhjwpku commented on code in PR #495:
URL: https://github.com/apache/iceberg-cpp/pull/495#discussion_r2671534416
##########
src/iceberg/transform_function.h:
##########
@@ -100,13 +100,14 @@ class ICEBERG_EXPORT TruncateTransform : public
TransformFunction {
int32_t width_;
};
-/// \brief Year transform that extracts the year component from timestamp
inputs.
+/// \brief Year transform that extracts the number of years from timestamp
inputs since
+/// the epoch.
class ICEBERG_EXPORT YearTransform : public TransformFunction {
public:
/// \param source_type Must be a timestamp type.
explicit YearTransform(std::shared_ptr<Type> const& source_type);
- /// \brief Extract a date or timestamp year, as years from 1970.
Review Comment:
This is the same as the spec[1], maybe we should keep this.
ditto for all the Transform methods comments.
[1] https://iceberg.apache.org/spec/#partition-transforms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
