Copilot commented on code in PR #14991:
URL: https://github.com/apache/iceberg/pull/14991#discussion_r2672144227
##########
spark/v4.0/build.gradle:
##########
@@ -324,7 +324,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra',
'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap',
'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is
`com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java
package name for RoaringBitmap remains `org.roaringbitmap`. The relocate
directive should use the Java package name, not the Maven coordinate. This
should be `relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'
```
##########
spark/v3.5/build.gradle:
##########
@@ -315,7 +315,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra',
'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap',
'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is
`com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java
package name for RoaringBitmap remains `org.roaringbitmap`. The relocate
directive should use the Java package name, not the Maven coordinate. This
should be `relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'
```
##########
spark/v4.1/build.gradle:
##########
@@ -334,7 +336,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra',
'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap',
'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is
`com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java
package name for RoaringBitmap remains `org.roaringbitmap`. The relocate
directive should use the Java package name, not the Maven coordinate. This
should be `relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'
```
##########
spark/v3.4/build.gradle:
##########
@@ -313,7 +313,7 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
relocate 'org.threeten.extra',
'org.apache.iceberg.shaded.org.threeten.extra'
- relocate 'org.roaringbitmap', 'org.apache.iceberg.shaded.org.roaringbitmap'
+ relocate 'com.github.RoaringBitmap.RoaringBitmap',
'org.apache.iceberg.shaded.com.github.RoaringBitmap.RoaringBitmap'
Review Comment:
The relocation pattern is incorrect. The new library artifact ID is
`com.github.RoaringBitmap.RoaringBitmap:roaringbitmap`, but the actual Java
package name for RoaringBitmap remains `org.roaringbitmap`. The relocate
directive should use the Java package name, not the Maven coordinate. This
should be `relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'`.
```suggestion
relocate 'org.roaringbitmap',
'org.apache.iceberg.shaded.org.roaringbitmap'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
