pvary commented on code in PR #14989:
URL: https://github.com/apache/iceberg/pull/14989#discussion_r2672767633
##########
core/src/main/java/org/apache/iceberg/BasePartitionStatistics.java:
##########
@@ -40,6 +41,22 @@ public class BasePartitionStatistics extends
SupportsIndexProjection
private static final int STATS_COUNT = 13;
+ public BasePartitionStatistics(StructLike partition, int specId) {
Review Comment:
Could this be package private?
##########
core/src/main/java/org/apache/iceberg/BasePartitionStatistics.java:
##########
@@ -40,6 +41,22 @@ public class BasePartitionStatistics extends
SupportsIndexProjection
private static final int STATS_COUNT = 13;
+ public BasePartitionStatistics(StructLike partition, int specId) {
+ super(STATS_COUNT);
+
+ this.partition = partition;
+ this.specId = specId;
+
+ this.dataRecordCount = 0L;
+ this.dataFileCount = 0;
+ this.totalDataFileSizeInBytes = 0L;
+ this.positionDeleteRecordCount = 0L;
+ this.positionDeleteFileCount = 0;
+ this.equalityDeleteRecordCount = 0L;
+ this.equalityDeleteFileCount = 0;
+ this.dvCount = 0;
+ }
+
/** Used by internal readers to instantiate this class with a projection
schema. */
public BasePartitionStatistics(Types.StructType projection) {
Review Comment:
Maybe even this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
