dhananjaykrutika commented on code in PR #671:
URL: https://github.com/apache/iceberg-go/pull/671#discussion_r2675567293
##########
table/transaction.go:
##########
@@ -241,7 +241,9 @@ func (t *Transaction) ExpireSnapshots(opts
...ExpireSnapshotsOpt) error {
for {
snap, err := t.meta.SnapshotByID(snapId)
if err != nil {
- return err
+ // Parent snapshot may have been removed by a
previous expiration.
+ // Treat missing parent as end of chain - this
is expected behavior.
+ break
Review Comment:
@twuebi not sure I understand. There's really only one reason
`SnapshotByID()` fails -- when the given snapshot ID doesn't exist in
`snapshotList` list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
