nastra commented on code in PR #14997:
URL: https://github.com/apache/iceberg/pull/14997#discussion_r2676518191
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -358,7 +367,9 @@ private boolean sameViewVersion(ViewVersion one,
ViewVersion two) {
&& Objects.equals(one.representations(), two.representations())
&& Objects.equals(one.defaultCatalog(), two.defaultCatalog())
&& Objects.equals(one.defaultNamespace(), two.defaultNamespace())
- && one.schemaId() == two.schemaId();
+ && (one.schemaId() == two.schemaId()
+ || (two.schemaId() == LAST_ADDED
+ && Objects.equals(lastSeenExistingSchemaId,
one.schemaId())));
Review Comment:
yes I agree that this should be made symmetrical. I was mostly exploring
this part to do proper deduplication for the edge case that we're testing for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
