zeroshade commented on code in PR #652:
URL: https://github.com/apache/iceberg-go/pull/652#discussion_r2676698646
##########
catalog/rest/rest.go:
##########
@@ -593,6 +593,15 @@ func (r *Catalog) createSession(ctx context.Context, opts
*options) (*http.Clien
}
cl := &http.Client{Transport: session}
+ for k, v := range opts.headers {
+ session.defaultHeaders.Set(k, v)
+ }
+
+ session.defaultHeaders.Set("X-Client-Version", icebergRestSpecVersion)
+ session.defaultHeaders.Set("Content-Type", "application/json")
+ session.defaultHeaders.Set("User-Agent", "GoIceberg/"+iceberg.Version())
+ session.defaultHeaders.Set("X-Iceberg-Access-Delegation",
"vended-credentials")
Review Comment:
I think this is the last piece we need before I'm comfortable with merging
this, unless anyone has any objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
