varun-lakhyani commented on code in PR #14933: URL: https://github.com/apache/iceberg/pull/14933#discussion_r2677357476
########## spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/actions/TestSnapshotTableAction.java: ########## @@ -18,12 +18,17 @@ */ package org.apache.iceberg.spark.actions; +import static org.apache.iceberg.CatalogUtil.ICEBERG_CATALOG_TYPE; +import static org.apache.iceberg.CatalogUtil.ICEBERG_CATALOG_TYPE_HADOOP; import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.assertj.core.api.Assumptions.assumeThat; import java.io.IOException; import java.nio.file.Files; import java.util.concurrent.Executors; import java.util.concurrent.atomic.AtomicInteger; +import org.apache.hadoop.fs.Path; Review Comment: Yes Correct, It was just used for creating nested path locations. Standard string operations are simpler and suitable than this. UPDATED in latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
