amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2678019059
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -269,7 +277,6 @@ private void addInternal(DeleteFile file) {
DeleteFileSet deleteFiles =
newDeleteFilesBySpec.computeIfAbsent(spec.specId(), ignored ->
DeleteFileSet.create());
if (deleteFiles.add(file)) {
- addedFilesSummary.addedFile(spec, file);
hasNewDeleteFiles = true;
if (ContentFileUtil.isDV(file)) {
newDVRefs.add(file.referencedDataFile());
Review Comment:
We also could just keep a mapping specific for duplicates. That shrinks down
how much work we need to do because instead of trying to group by every
referenced data file in case of duplicates, we just go through the duplicates
set. It's maybe a little more memory but if we consider that we expect
duplicates to generally be rare it feels like a generally better solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
