Fokko commented on code in PR #2871:
URL: https://github.com/apache/iceberg-python/pull/2871#discussion_r2682130112
##########
pyiceberg/table/__init__.py:
##########
@@ -275,8 +275,20 @@ def __exit__(self, exctype: type[BaseException] | None,
excinst: BaseException |
if exctype is None and excinst is None and exctb is None:
self.commit_transaction()
- def _apply(self, updates: tuple[TableUpdate, ...], requirements:
tuple[TableRequirement, ...] = ()) -> Transaction:
- """Check if the requirements are met, and applies the updates to the
metadata."""
+ def _stage(
Review Comment:
> WDYT about adding this helper method to the base Transaction class?
I'm not sure if I'm following. This is already part of `Transaction`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
