pvary commented on pull request #1748:
URL: https://github.com/apache/iceberg/pull/1748#issuecomment-726724055


   @massdosage: I try to answer all of the open questions - might miss some, so 
please feel free to point them out.
   
   - The property `iceberg.engine.hive.enabled`/`engine.hive.enabled` only 
controls how the HMS metadata values are set 
(InputFormat/OutputFormat/SerDe/StorageHandler)
   - There are different DDLs for different catalogs, these should work since 
they are tested with the unit tests as well
   ```
   -- empty iceberg.mr.catalog means HadoopTables
   
   -- new table Hive + Iceberg
   CREATE EXTERNAL TABLE customers 
   STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
   LOCATION '<LOCATION>'
   TBLPROPERTIES ('iceberg.mr.table.schema'='<SCHEMA_JSON>', 
'iceberg.mr.table.partition.spec'='<PART_SPEC_JSON>');
   
   -- new Hive table above existing Iceberg table
   CREATE EXTERNAL TABLE customers 
   STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
   LOCATION '<LOCATION>';
   
   -- HadoopCatalog (same as HadoopTables)
   set iceberg.mr.catalog=hadoop;
   
   -- new table Hive + Iceberg
   CREATE EXTERNAL TABLE customers 
   STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
   LOCATION '<LOCATION>'
   TBLPROPERTIES ('iceberg.mr.table.schema'='<SCHEMA_JSON>', 
'iceberg.mr.table.partition.spec'='<PART_SPEC_JSON>');
   
   -- new Hive table above existing Iceberg table
   CREATE EXTERNAL TABLE customers 
   STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
   LOCATION '<LOCATION>';
   
   -- HiveCatalog
   set iceberg.mr.catalog=hive;
   
   -- new table Hive + Iceberg
   CREATE EXTERNAL TABLE customers 
   STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
   TBLPROPERTIES ('iceberg.mr.table.schema'='<SCHEMA_JSON>', 
'iceberg.mr.table.partition.spec'='<PART_SPEC_JSON>');
   
   -- new Hive table above existing Iceberg table is an invalid case
   ```
   - You might provide the Schema json when creating the table, but the 
property should not be present on the created HMS table.
   - You said that you have problem selecting data from the tables. What is the 
exact Exception?
   
   Thanks, and sorry for chiming in late 😢 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to