Fokko commented on code in PR #2864:
URL: https://github.com/apache/iceberg-python/pull/2864#discussion_r2682185260
##########
pyiceberg/catalog/rest/scan_planning.py:
##########
@@ -25,9 +25,16 @@
from pyiceberg.catalog.rest.response import ErrorResponseMessage
from pyiceberg.expressions import BooleanExpression,
SerializableBooleanExpression
-from pyiceberg.manifest import FileFormat
+from pyiceberg.manifest import DataFileContent, FileFormat
from pyiceberg.typedef import IcebergBaseModel
+# REST content-type to DataFileContent
+CONTENT_TYPE_MAP: dict[str, DataFileContent] = {
+ "data": DataFileContent.DATA,
+ "position-deletes": DataFileContent.POSITION_DELETES,
+ "equality-deletes": DataFileContent.EQUALITY_DELETES,
+}
Review Comment:
Should we move this to a static method on `DataFileContent`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
