RussellSpitzer commented on code in PR #14947:
URL: https://github.com/apache/iceberg/pull/14947#discussion_r2683984911
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -465,6 +464,10 @@ public void commit() {
// to ensure that if a concurrent operation assigns the
UUID, this operation will
// not fail.
taskOps.commit(base, updated.withUUID());
+
+ // Set the staged snapshot AFTER successful commit to ensure
cleanup uses
+ // the actually committed snapshot, not one from a
failed/no-op attempt
Review Comment:
If I fail with a not "CommitFailedException" at this point won't I fail to
clean up the snapshot?
I should have been more clear here, if I don't retry, I can possibly fail
without every reaching this point and stagedSnapshot will then have a null
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
