nssalian opened a new pull request, #2906:
URL: https://github.com/apache/iceberg-python/pull/2906
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #2870 -->
# Rationale for this change
Eliminates code duplication between `test_base.py` and `test_sql.py` by
consolidating shared catalog behavior tests into a single parameterized test
suite. This ensures consistent behavior testing across both catalog
implementations and makes it easier to add new catalog implementations with
shared test coverage.
## Changes
- New `tests/catalog/test_catalog_behaviors.py` with parameterized tests
covering both catalogs
- New `tests/catalog/conftest.py` with shared fixtures for catalog testing
- Reduced `test_base.py` to InMemoryCatalog-specific tests
- Reduced `test_sql.py` to SqlCatalog-specific tests
- Fixed return type annotation for `test_partition_spec` fixture in
`tests/conftest.py`
- Removed an import from `tests/table/test_upsert.py`
## Are these changes tested?
`make test` ran successfully locally
## Are there any user-facing changes?
No
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]