wgtmac commented on code in PR #503:
URL: https://github.com/apache/iceberg-cpp/pull/503#discussion_r2685432846
##########
src/iceberg/expression/binder.cc:
##########
@@ -92,11 +92,13 @@ Result<bool> IsBoundVisitor::AlwaysFalse() { return true; }
Result<bool> IsBoundVisitor::Not(bool child_result) { return child_result; }
Result<bool> IsBoundVisitor::And(bool left_result, bool right_result) {
- return left_result && right_result;
+ ICEBERG_PRECHECK(left_result == right_result, "Found partially bound
expression");
Review Comment:
I don't think this is correct. If we want to keep the same behavior as the
Java impl, we might need to return error for `AlwaysTrue()` and `AlwaysFalse()`
and then revert changes to `And` and `Or`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
