wgtmac commented on code in PR #479: URL: https://github.com/apache/iceberg-cpp/pull/479#discussion_r2690978271
########## src/iceberg/catalog/rest/CMakeLists.txt: ########## @@ -15,6 +15,9 @@ # specific language governing permissions and limitations # under the License. +# Include auth subdirectory Review Comment: ```suggestion ``` This comment is unnecessary. ########## src/iceberg/catalog/rest/auth/CMakeLists.txt: ########## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set(ICEBERG_REST_AUTH_SOURCES auth_session.cc auth_manager.cc auth_managers.cc) + +# Expose sources to parent scope for inclusion in iceberg_rest library +set(ICEBERG_REST_AUTH_SOURCES + ${ICEBERG_REST_AUTH_SOURCES} + PARENT_SCOPE) Review Comment: ```suggestion iceberg_install_all_headers(iceberg/catalog/rest/auth) ``` The current pattern is inconsistent with other CMake config. We should only install headers for this subdirectory here. ########## src/iceberg/catalog/rest/type_fwd.h: ########## @@ -34,3 +34,11 @@ class RestCatalog; class RestCatalogProperties; } // namespace iceberg::rest + +namespace iceberg::rest::auth { Review Comment: Do we really need the extra `auth` namespace? ########## src/iceberg/catalog/rest/CMakeLists.txt: ########## @@ -26,6 +29,11 @@ set(ICEBERG_REST_SOURCES rest_util.cc types.cc) +# Add auth sources with proper path prefix +foreach(AUTH_SOURCE ${ICEBERG_REST_AUTH_SOURCES}) + list(APPEND ICEBERG_REST_SOURCES "auth/${AUTH_SOURCE}") +endforeach() + Review Comment: ```suggestion ``` Let's remove these lines by directly adding those files in the above `set(ICEBERG_REST_SOURCES)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
