xbattlax commented on issue #1893: URL: https://github.com/apache/iceberg-rust/issues/1893#issuecomment-3750371051
## Questions about Task 3: Explicit Catalog Support Before implementing explicit catalog support for HMS 3.x, I have a few questions: ### 1. Backward Compatibility The `hive_metastore` Thrift crate already has optional `catName`/`catalogName` fields in structs (`Database`, `Table`, `Partition`). If we set these fields when talking to an HMS 2.x server that doesn't support multi-catalog, will it: - Ignore the field silently? - Return an error? Should we add a version check or just document that `catalog_name` config requires HMS 3.x? ### 2. Testing Environment Testing requires an HMS 3.x instance with multi-catalog enabled. Options: - Add integration test that only runs if HMS 3.x is detected - Unit tests only for the conversion functions - Skip automated testing and document manual steps What's the preferred approach for this project? ### 3. Scope Clarification The Java Iceberg `HiveCatalog` doesn't currently propagate catalog names to HMS either (the `name` field is just for identification). Is the goal here to: - Match Java behavior (catalog name for identification only)? - Go beyond Java and actually use HMS 3.x multi-catalog feature? @vladson - as the issue author, do you have a specific use case in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
