obelix74 commented on code in PR #14360:
URL: https://github.com/apache/iceberg/pull/14360#discussion_r2691578869
##########
gradle/libs.versions.toml:
##########
@@ -166,6 +167,7 @@ microprofile-openapi-api = { module =
"org.eclipse.microprofile.openapi:micropro
nessie-client = { module = "org.projectnessie.nessie:nessie-client",
version.ref = "nessie" }
netty-buffer = { module = "io.netty:netty-buffer", version.ref =
"netty-buffer" }
object-client-bundle = { module = "com.emc.ecs:object-client-bundle",
version.ref = "object-client-bundle" }
+opentelemetry-httpclient = { module =
"io.opentelemetry.instrumentation:opentelemetry-apache-httpclient-5.2",
version.ref = "opentelemetry-httpclient" }
Review Comment:
This pins an alpha OTel instrumentation artifact (2.20.1-alpha) and the
module name is specifically opentelemetry-apache-httpclient-5.2 while Iceberg
uses Apache HttpClient 5.6. Can we confirm this instrumentation is compatible
with 5.6 (and that pulling opentelemetry-api-incubator alpha transitively is
acceptable here)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
