CTTY commented on code in PR #2000:
URL: https://github.com/apache/iceberg-rust/pull/2000#discussion_r2692141070
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -78,7 +78,7 @@ impl IcebergTableProvider {
///
/// Loads the table once to get the initial schema, then stores the catalog
/// reference for future metadata refreshes on each operation.
- pub(crate) async fn try_new(
+ pub async fn try_new(
Review Comment:
+1, I don't think this should be made public. It's more recommended to use
`IcebergCatalogProvider` indirectly register table providers. But would love to
hear the use case if any
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
