kevinjqliu commented on code in PR #2890:
URL: https://github.com/apache/iceberg-python/pull/2890#discussion_r2692784017
##########
tests/catalog/test_rest.py:
##########
@@ -2155,3 +2156,86 @@ def test_view_endpoints_enabled_with_config(self,
requests_mock: Mocker) -> None
# View endpoints should be supported when enabled
catalog._check_endpoint(Capability.V1_LIST_VIEWS)
catalog._check_endpoint(Capability.V1_DELETE_VIEW)
+
+
+def test_table_uuid_check_on_commit(rest_mock: Mocker,
example_table_metadata_v2: dict[str, Any]) -> None:
Review Comment:
yea, as the other comment pointed out, this is purely defensive in case the
catalog isnt doing the right thing 🤷
imo, it doesn't hurt to check again after the table response
I dont like the mocks either, but i dont see another way to test this logic
haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
