gaborkaszab commented on PR #15045: URL: https://github.com/apache/iceberg/pull/15045#issuecomment-3754106691
Thanks for the explanation, @danielcweeks ! I'm fine with the change apart from that really minor suggestion I made earlier. I'd like to add one interesting note wrt the server-side calculation of ETags: Not just loadTable response has ETag, but only loadTable has snapshot mode param. For instance following the `hash(metadata_location, params)` idea createTable, registerTable, etc. would give a different ETag than loadTable for the very same table state. I don't think this is dealbreaker because currently only loadTable uses tableCache, but could be misleading. For instance createTable should give the same ETag as the loadTable with snapshots=all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
