alessandro-nori commented on code in PR #15051:
URL: https://github.com/apache/iceberg/pull/15051#discussion_r2694222150
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -169,7 +169,7 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
.addAll(metadata.changes())
.build();
requirements = UpdateRequirements.forCreateTable(updates);
- errorHandler = ErrorHandlers.tableErrorHandler(); // throws
NoSuchTableException
+ errorHandler = ErrorHandlers.tableCommitHandler(); // throws
NoSuchTableException
Review Comment:
what do you think about 409?
I was not sure if it was ok to return a CommitFailedException instead of a
TableAlreadyExists exception
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -169,7 +169,7 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
.addAll(metadata.changes())
.build();
requirements = UpdateRequirements.forCreateTable(updates);
- errorHandler = ErrorHandlers.tableErrorHandler(); // throws
NoSuchTableException
+ errorHandler = ErrorHandlers.tableCommitHandler(); // throws
NoSuchTableException
Review Comment:
what do you think about 409?
I was not sure if in this case it was ok to return a CommitFailedException
instead of a TableAlreadyExists exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
