huaxingao commented on code in PR #14751:
URL: https://github.com/apache/iceberg/pull/14751#discussion_r2697160386
##########
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedKey.java:
##########
@@ -33,7 +33,7 @@ public BaseEncryptedKey(
Preconditions.checkArgument(keyId != null, "Key id cannot be null");
Preconditions.checkArgument(keyMetadata != null, "Encrypted key metadata
cannot be null");
this.keyId = keyId;
- this.keyMetadata = keyMetadata;
+ this.keyMetadata = keyMetadata.array();
Review Comment:
nit: could we change to `this.keyMetadata =
ByteBuffers.toByteArray(keyMetadata);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
