varun-lakhyani commented on code in PR #15028:
URL: https://github.com/apache/iceberg/pull/15028#discussion_r2697829854
##########
spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMergeSchemaEvolution.java:
##########
@@ -185,6 +185,46 @@ public void testMergeWithSchemaEvolutionNestedStruct() {
sql("SELECT id, s FROM %s ORDER BY id", selectTarget()));
}
+ @TestTemplate
+ public void testMergeWithSchemaEvolutionNestedStructSourceHasFewerFields() {
+ assumeThat(branch).as("Schema evolution does not work for branches
currently").isNull();
+
+ spark.conf().set("spark.sql.mergeNestedTypeCoercion.enabled", "true");
Review Comment:
Yes correct, There is withSQLConf at
`spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/TestBase.java::186`
which handles spark configs required for some action and It handles try block
in its implementation.
I took reference from `testMergeToWapBranch()` at
`spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java::2914`
which implements similar thing.
Ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
