nastra commented on code in PR #14398:
URL: https://github.com/apache/iceberg/pull/14398#discussion_r2698399415
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2943,17 +2951,14 @@ public void testNotModified() {
any(),
any());
- // TODO: This won't throw when client side of freshness-aware loading is
implemented
- assertThatThrownBy(() ->
catalog().loadTable(TABLE)).isInstanceOf(NullPointerException.class);
+ catalog().loadTable(TABLE);
Review Comment:
since you mentioned that you'll open a separate PR in order to move the
tests, let's just move all of the improvements around testing into that
separate PR. That way we can get these changes in and tackle everything
test-related there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
