lishuxu commented on code in PR #479: URL: https://github.com/apache/iceberg-cpp/pull/479#discussion_r2700600681
########## src/iceberg/catalog/rest/auth/auth_managers.h: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <functional> +#include <memory> +#include <string> +#include <string_view> +#include <unordered_map> + +#include "iceberg/catalog/rest/auth/auth_manager.h" +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/result.h" +#include "iceberg/util/string_util.h" + +/// \file iceberg/catalog/rest/auth/auth_managers.h +/// \brief Factory for creating authentication managers. + +namespace iceberg::rest::auth { + +/// \brief Function that builds an AuthManager for a given catalog. +/// +/// \param name Catalog name passed to the manager. +/// \param properties Consolidated catalog configuration. +/// \return Newly created manager instance. +using AuthManagerFactory = std::function<std::unique_ptr<AuthManager>( + std::string_view name, + const std::unordered_map<std::string, std::string>& properties)>; + +/// \brief Registry type for AuthManager factories with heterogeneous lookup support. +using AuthManagerRegistry = + std::unordered_map<std::string, AuthManagerFactory, StringHash, StringEqual>; + +/// \brief Registry-backed factory for AuthManager implementations. +class ICEBERG_REST_EXPORT AuthManagers { + public: + /// \brief Load a manager by consulting the "rest.auth.type" configuration. + /// + /// \param name Catalog name passed to the manager. Review Comment: I meant the auth type, not the catalog itself. To avoid ambiguity, I have changed it to “Name of the auth manager.” -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
