pvary commented on code in PR #14729:
URL: https://github.com/apache/iceberg/pull/14729#discussion_r2704074407
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestEvolveSchemaVisitor.java:
##########
@@ -94,7 +94,7 @@ private static Types.NestedField[] primitiveFields(
public void testAddTopLevelPrimitives() {
Schema targetSchema = new Schema(primitiveFields(0, primitiveTypes()));
UpdateSchema updateApi = loadUpdateApi(new Schema());
- EvolveSchemaVisitor.visit(TABLE, updateApi, new Schema(), targetSchema,
PRESERVE_COLUMNS);
+ EvolveSchemaVisitor.visit(TABLE, updateApi, new Schema(), targetSchema,
true, PRESERVE_COLUMNS);
Review Comment:
Could we use a constant for this, similar to `PRESERVE_COLUMNS`. It will be
more descriptive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
