amogh-jahagirdar commented on code in PR #15070:
URL: https://github.com/apache/iceberg/pull/15070#discussion_r2706904148
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java:
##########
@@ -740,6 +740,7 @@ public void testNaN() {
sql(
"INSERT INTO %s VALUES (1, float('nan')),"
+ "(1, float('nan')), "
+ + "(1, 10.0), "
Review Comment:
Interesting, it's a bit unclear to me why the additional row would trigger
collecting lower/upper bounds. I'd have to double check if there's some minimum
threshold of rows or some other condition that controls whether lower/upper is
written when the footer is written. Looking at this test without the change I
would've expected a lower/upper bounds of 1.0 and 2.0 respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
