zhjwpku commented on code in PR #516: URL: https://github.com/apache/iceberg-cpp/pull/516#discussion_r2707231552
########## src/iceberg/update/fast_append.cc: ########## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "iceberg/update/fast_append.h" + +#include <iterator> +#include <ranges> +#include <vector> + +#include "iceberg/constants.h" +#include "iceberg/manifest/manifest_entry.h" +#include "iceberg/manifest/manifest_util_internal.h" +#include "iceberg/snapshot.h" +#include "iceberg/table.h" +#include "iceberg/table_metadata.h" +#include "iceberg/table_properties.h" +#include "iceberg/transaction.h" +#include "iceberg/util/error_collector.h" +#include "iceberg/util/macros.h" + +namespace iceberg { + +Result<std::unique_ptr<FastAppend>> FastAppend::Make( + std::string table_name, std::shared_ptr<Transaction> transaction) { + ICEBERG_PRECHECK(!table_name.empty(), "Table name cannot be empty"); + ICEBERG_PRECHECK(transaction != nullptr, + "Cannot create FastAppend without a transaction"); + return std::unique_ptr<FastAppend>( + new FastAppend(std::move(table_name), std::move(transaction))); +} + +FastAppend::FastAppend(std::string table_name, std::shared_ptr<Transaction> transaction) + : SnapshotUpdate(std::move(transaction)), table_name_(std::move(table_name)) {} + +FastAppend& FastAppend::AppendFile(std::shared_ptr<DataFile> file) { + ICEBERG_BUILDER_CHECK(file != nullptr, "Invalid data file: null"); + ICEBERG_BUILDER_CHECK(file->partition_spec_id.has_value(), + "Data file must have partition spec ID"); + + int32_t spec_id = file->partition_spec_id.value(); + ICEBERG_BUILDER_ASSIGN_OR_RETURN(auto spec, Spec(spec_id)); + + auto& data_files = new_data_files_by_spec_[spec_id]; + auto [iter, inserted] = data_files.insert(file); + if (inserted) { + has_new_files_ = true; + ICEBERG_BUILDER_RETURN_IF_ERROR(summary_.AddedFile(*spec, *file)); + } + + return *this; +} + +FastAppend& FastAppend::AppendManifest(const ManifestFile& manifest) { + ICEBERG_BUILDER_CHECK(!manifest.has_existing_files(), + "Cannot append manifest with existing files"); + ICEBERG_BUILDER_CHECK(!manifest.has_deleted_files(), + "Cannot append manifest with deleted files"); + ICEBERG_BUILDER_CHECK(manifest.added_snapshot_id == kInvalidSnapshotId, + "Snapshot id must be assigned during commit"); + ICEBERG_BUILDER_CHECK(manifest.sequence_number == kInvalidSequenceNumber, + "Sequence number must be assigned during commit"); + + if (can_inherit_snapshot_id() && manifest.added_snapshot_id == kInvalidSnapshotId) { + summary_.AddedManifest(manifest); + append_manifests_.push_back(manifest); + } else { + // The manifest must be rewritten with this update's snapshot ID + ICEBERG_BUILDER_ASSIGN_OR_RETURN(auto copied_manifest, CopyManifest(manifest)); + rewritten_append_manifests_.push_back(std::move(copied_manifest)); + } + + return *this; +} + +FastAppend& FastAppend::ToBranch(const std::string& branch) { Review Comment: Sure, removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
