smaheshwar-pltr commented on code in PR #15092:
URL: https://github.com/apache/iceberg/pull/15092#discussion_r2709222903
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -459,10 +467,40 @@ private void deleteUncommittedFiles(Iterable<String>
paths) {
}
private void applyUpdates(TableOperations underlyingOps) {
- if (base != underlyingOps.refresh()) {
- // use refreshed the metadata
+ try {
+ underlyingOps.refresh();
Review Comment:
TODO:
`TestHiveCreateReplaceTable#testCreateOrReplaceTableTxnTableDeletedConcurrently`
shows an NPE where this refresh actually returns null instead of
`NoSuchTableException` being thrown. Consider handling that here, fixing if
it's a bug, or leaving for now (as that's maybe how concurrent appends with
dropped failed prior to this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
