smaheshwar-pltr commented on code in PR #15061: URL: https://github.com/apache/iceberg/pull/15061#discussion_r2713886099
########## spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestCustomSnapshot.java: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.source; + +import static org.assertj.core.api.Assertions.assertThat; + +import java.util.List; +import org.apache.iceberg.ParameterizedTestExtension; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.Table; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.spark.TestBaseWithCatalog; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.TestTemplate; +import org.junit.jupiter.api.extension.ExtendWith; + +@ExtendWith(ParameterizedTestExtension.class) +public class TestCustomSnapshot extends TestBaseWithCatalog { + + @BeforeEach + public void setupTable() { + sql("CREATE TABLE %s (id INT, data STRING) USING iceberg", tableName); + } + + @AfterEach + public void dropTable() { + sql("DROP TABLE IF EXISTS %s", tableName); + } + + @TestTemplate + public void testDeleteWithSessionConfig() { + sql("INSERT INTO %s VALUES (1, 'a'), (2, 'b')", tableName); Review Comment: Minor: I think that all deletions in these tests actually result in DELETE snapshots due to filters matching entire files - though that's what this PR fixes, I think it'd also be nice to test row-level deletes also. It'd be nice maybe to have a test that does a DELETE resulting in an overwrite (and asserts that the snapshot operation is an `overwrite`) and checks for properties, and a separate one resulting in a `delete` operation too, to cover both cases. (Maybe similar tests for UPDATE commands too). WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
