smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2714058066
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1181,6 +1195,7 @@ private FileIO tableFileIO(
* @param mutationHeaderSupplier a supplier for additional HTTP headers to
include in mutation
* requests (POST/DELETE)
* @param fileIO the FileIO implementation for reading and writing table
metadata and data files
+ * @param kmsClient the {@link KeyManagementClient} for encrypted tables
Review Comment:
Pointing out that I'm changing the signature of this method.
https://github.com/apache/iceberg/pull/14740 did the same recently, and I think
https://github.com/apache/iceberg/pull/14465 that hasn't released yet so there
shouldn't be problems with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
