peach12345 commented on code in PR #14932:
URL: https://github.com/apache/iceberg/pull/14932#discussion_r2719790620
##########
api/src/main/java/org/apache/iceberg/catalog/TableIdentifier.java:
##########
@@ -26,10 +27,10 @@
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
/** Identifies a table in iceberg catalog. */
-public class TableIdentifier {
+public class TableIdentifier implements Serializable {
Review Comment:
Yes, you’re right. When using the parse function, dots are treated as
separators.
Maybe parsing isn’t the best approach in this case. Would it make more sense
to work with the complete object instead? Would of course be a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
