wgtmac commented on code in PR #538:
URL: https://github.com/apache/iceberg-cpp/pull/538#discussion_r2730121456
##########
src/iceberg/test/CMakeLists.txt:
##########
@@ -181,7 +181,8 @@ if(ICEBERG_BUILD_BUNDLE)
update_properties_test.cc
update_schema_test.cc
update_sort_order_test.cc
- update_statistics_test.cc)
+ update_statistics_test.cc
+ update_partition_statistics_test.cc)
Review Comment:
sort it alphabetically
##########
src/iceberg/table_metadata.cc:
##########
@@ -1208,6 +1211,41 @@ Status
TableMetadataBuilder::Impl::RemoveStatistics(int64_t snapshot_id) {
return {};
}
+Status TableMetadataBuilder::Impl::SetPartitionStatistics(
+ std::shared_ptr<PartitionStatisticsFile> partition_statistics_file) {
+ ICEBERG_PRECHECK(partition_statistics_file != nullptr,
Review Comment:
nit: it should be a noop per the java impl. It is fine to error in our case
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
