geruh commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2730507009
##########
mkdocs/docs/api.md:
##########
@@ -80,6 +80,15 @@ Or, list existing namespaces:
ns = catalog.list_namespaces()
assert ns == [("docs_example",)]
+
+# Load namespace properties
+properties = catalog.load_namespace_properties("docs_example")
+
+# Update namespace properties
+catalog.update_namespace_properties("docs_example", updates={"owner":
"iceberg"})
Review Comment:
Nit: not blocking but maybe we can add that we can remove properties with
the `removals` param:
```
catalog.update_namespace_properties("docs_example",
removals={"remove-meee!"}, updates={"owner": "iceberg"})
```
##########
mkdocs/docs/api.md:
##########
@@ -165,8 +174,20 @@ with
catalog.create_table_transaction(identifier="docs_example.bids", schema=sch
update_spec.add_identity("symbol")
txn.set_properties(test_a="test_aa", test_b="test_b", test_c="test_c")
+
+## Register a table
+
+To register a table using existing metadata:
+
+```python
+catalog.register_table(
+ identifier="docs_example.bids",
+ metadata_location="s3://warehouse/path/to/metadata.json"
+)
```
+```python
Review Comment:
I think there is an orphaned code block here
<img width="932" height="348" alt="Image"
src="https://github.com/user-attachments/assets/327ffbe9-5340-4fb0-b3ec-a7b38df81167";
/>
##########
mkdocs/docs/api.md:
##########
@@ -165,8 +174,20 @@ with
catalog.create_table_transaction(identifier="docs_example.bids", schema=sch
update_spec.add_identity("symbol")
txn.set_properties(test_a="test_aa", test_b="test_b", test_c="test_c")
+
Review Comment:
You lost the closing code block back ticks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
