nastra commented on code in PR #14927: URL: https://github.com/apache/iceberg/pull/14927#discussion_r2735704093
########## core/src/test/java/org/apache/iceberg/rest/TestErrorHandlers.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest; + +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import org.apache.iceberg.exceptions.RESTException; +import org.apache.iceberg.rest.responses.ErrorResponse; +import org.junit.jupiter.api.Test; + +public class TestErrorHandlers { + + @Test + public void errorHandlerIncludesCodeAndType() { + ErrorResponse error = + ErrorResponse.builder() + .responseCode(422) + .withType("ValidationException") + .withMessage("Invalid input") + .build(); + + assertThatThrownBy(() -> ErrorHandlers.defaultErrorHandler().accept(error)) + .isInstanceOf(RESTException.class) + .hasMessage("Unable to process (code: 422, type: ValidationException): Invalid input"); + } + + @Test + public void errorHandlerWithCodeOnly() { + ErrorResponse error = ErrorResponse.builder().responseCode(422).build(); + + assertThatThrownBy(() -> ErrorHandlers.defaultErrorHandler().accept(error)) + .isInstanceOf(RESTException.class) + .hasMessage("Unable to process (code: 422, type: null): null"); + } + + @Test + public void errorHandlerWithCodeAndMessageOnly() { + ErrorResponse error = + ErrorResponse.builder().responseCode(422).withMessage("Invalid input").build(); + + assertThatThrownBy(() -> ErrorHandlers.defaultErrorHandler().accept(error)) + .isInstanceOf(RESTException.class) + .hasMessage("Unable to process (code: 422, type: null): Invalid input"); + } + + @Test + public void errorHandlerWithCodeAndTypeOnly() { + ErrorResponse error = + ErrorResponse.builder().responseCode(422).withType("ValidationException").build(); + + assertThatThrownBy(() -> ErrorHandlers.defaultErrorHandler().accept(error)) + .isInstanceOf(RESTException.class) + .hasMessage("Unable to process (code: 422, type: ValidationException): null"); + } + + @Test + public void errorHandlerFor405() { Review Comment: I think I would remove this test for now because we mainly care about that the additional info properly shows up in the error msg. I think this test can go into the follow-up PRs where inconsistencies around error code handling are dealt with -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
