kevinjqliu commented on code in PR #2974:
URL: https://github.com/apache/iceberg-python/pull/2974#discussion_r2739471425
##########
pyiceberg/catalog/rest/auth.py:
##########
@@ -249,6 +249,68 @@ def auth_header(self) -> str:
return f"Bearer {self.credentials.token}"
+class EntraAuthManager(AuthManager):
+ """Auth Manager implementation that supports Microsoft Entra ID (Azure AD)
authentication.
+
+ This manager uses the Azure Identity library's DefaultAzureCredential
which automatically
+ tries multiple authentication methods including environment variables,
managed identity,
+ and Azure CLI.
+
+ See
https://learn.microsoft.com/en-us/azure/developer/python/sdk/authentication/credential-chains
+ for more details on DefaultAzureCredential.
+ """
+
+ DEFAULT_SCOPE = "https://storage.azure.com/.default";
+
+ def __init__(
+ self,
+ scopes: list[str] | None = None,
Review Comment:
that would make the param a mutable list (and shared across calls) which is
generally discouraged in python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
