kevinjqliu commented on issue #2068: URL: https://github.com/apache/iceberg-rust/issues/2068#issuecomment-3821760726
i dug into this a bit. Looks like in iceberg-rust, the database schema for SqlCatalog contains the `iceberg_type` column. https://github.com/apache/iceberg-rust/blob/c56411a31945591dc600b95206d956ce0a7bb85c/crates/catalog/sql/src/catalog.rs#L259 However, this is not the case in pyiceberg and java's implementation: https://github.com/apache/iceberg-python/blob/062a252dd9f0f445ed5062a950db9ebd26682406/pyiceberg/catalog/sql.py#L84-L91 https://github.com/apache/iceberg/blob/8072acd66e69bd0888ca67c8ffb9b213501be8fc/core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java#L126-L147 Perhaps we can make `iceberg_type` optional and eventually removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
