nastra commented on code in PR #14859:
URL: https://github.com/apache/iceberg/pull/14859#discussion_r2745058232
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -565,6 +565,83 @@ public void testPositionDeletesAcrossFiles() throws
Exception {
.isEmpty();
}
+ /**
+ * Test for https://github.com/apache/iceberg/issues/14814
+ *
+ * <p>When multiple tags/refs point to the same snapshot containing
positional deletes, the
+ * rewrite_table_path action was throwing AlreadyExistsException because the
same delete file was
+ * being processed multiple times. The fix uses DeleteFileSet to properly
deduplicate delete files
+ * based on file location, content offset, and content size.
+ */
+ @TestTemplate
+ public void testPositionDeletesWithMultipleTagsOnSameSnapshot() throws
Exception {
Review Comment:
I don't think this test actually reproduces the issue because the test
passes for me even without the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
