bodduv commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2746671667
##########
api/src/main/java/org/apache/iceberg/expressions/ManifestEvaluator.java:
##########
@@ -64,7 +68,15 @@ public static ManifestEvaluator forPartitionFilter(
}
private ManifestEvaluator(PartitionSpec spec, Expression partitionFilter,
boolean caseSensitive) {
- this.expr = Binder.bind(spec.partitionType(), rewriteNot(partitionFilter),
caseSensitive);
+ Types.StructType partitionType = spec.partitionType();
+ Expression rewritten = rewriteNot(partitionFilter);
+ this.expr = Binder.bind(partitionType, rewritten, caseSensitive);
+
+ // Create the signed UUID expression if and only if there are UUID
predicates
+ // that compare against bounds.
+ Expression transformed = ExpressionUtil.toSignedUUIDLiteral(rewritten);
Review Comment:
Yes, we can check if we need to evaluate a second (`signedUuidExpr`) or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
