adutra commented on PR #15192:
URL: https://github.com/apache/iceberg/pull/15192#issuecomment-3828970768
Another problem that I'm not fixing for now is that the test only works for
catalogs with local storage since it creates files on the local filesystem. It
does not work with `S3FileIO` for example (we have plenty of those in Polaris
tests).
If possible I also would like to rewrite the test as follows:
```java
... // same setup
table.io().deleteFile(metadataFileLocation);
catalog.invalidateTable(TBL);
assertThatThrownBy(() -> catalog.loadTable(TBL))
.isInstanceOf(NotFoundException.class)
.hasMessageContaining(metadataFileLocation);
```
@gaborkaszab do you know why the test needs to use `Path` instances? Do you
agree with the modified version above? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
