lishuxu commented on code in PR #544:
URL: https://github.com/apache/iceberg-cpp/pull/544#discussion_r2757344911
##########
src/iceberg/catalog/rest/rest_catalog.cc:
##########
@@ -65,13 +68,19 @@ std::unordered_set<Endpoint> GetDefaultEndpoints() {
};
}
-/// \brief Fetch server config and merge it with client config
-Result<CatalogConfig> FetchServerConfig(const ResourcePaths& paths,
- const RestCatalogProperties&
current_config) {
+/// \brief Fetch server configuration from the REST catalog server.
+Result<CatalogConfig> FetchServerConfig(
+ const ResourcePaths& paths, const RestCatalogProperties& current_config,
+ const std::shared_ptr<auth::AuthSession>& session) {
Review Comment:
Changed the session argument type to auth::AuthSession&. Authenticate() is
non-const to support OAuth2 token refresh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
