bodduv commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2758504171
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java:
##########
@@ -56,14 +56,25 @@ public class InclusiveMetricsEvaluator {
private static final int IN_PREDICATE_LIMIT = 200;
private final Expression expr;
+ // Expression using signed UUID comparator for backward compatibility with
files written
+ // prior to the introduction of RFC-compliant UUID comparisons.
+ // Null if there are no UUID predicates comparing against bounds in the
expression.
+ private final Expression signedUuidExpr;
Review Comment:
`Literal.comparator().compare(...)` returns evaluation for a single node of
the `Expression`, .e.g `lt` or `ge`. I believe we need to respect the presence
of `NOT` or negation type of nodes in the `Expression`, and therefore, evaluate
the entire `Expression` twice and then do an `OR` between them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
