adutra commented on code in PR #15168:
URL: https://github.com/apache/iceberg/pull/15168#discussion_r2759231709
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3V4RestSignerClient.java:
##########
@@ -169,4 +171,34 @@ public static Stream<Arguments> validOAuth2Properties() {
"custom",
"token"));
}
+
+ @ParameterizedTest
+ @MethodSource("validRequestProperties")
+ void requestProperties(Map<String, String> input, Map<String, String>
expected) throws Exception {
+ Map<String, String> properties =
+ ImmutableMap.<String, String>builder()
+ .put(S3_SIGNER_URI, "https://signer.com";)
+ .putAll(input)
+ .build();
+
+ try (S3V4RestSignerClient client =
+
ImmutableS3V4RestSignerClient.builder().properties(properties).build()) {
+ Map<String, String> signerProperties =
client.requestPropertiesSupplier().get();
+ assertThat(signerProperties).isEqualTo(expected);
Review Comment:
`containsOnly` is for a single `Map.Entry`. Did you mean
`containsAllEntriesOf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
