omerhadari opened a new pull request, #15226: URL: https://github.com/apache/iceberg/pull/15226
When partial progress is enabled and a commit fails, the file groups in that batch were previously lost. When looking at the result, `failedDataFilesCount` is `0` when commits failed. When some commits failed and some succeeded, it's unclear by looking at the result that it is actually partial. One choice I'm not sure about and am happy to get feedback on is that this change makes it so the creation of result objects now treats commit failures as other rewrite failures (both failure count and failed data files). Given the aggregative nature of the result object, I couldn't think of a situation where the distinction is important enough to justify changing its structure, but I am open to changing it to be counted separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
