amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2761694001
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -1060,9 +1062,32 @@ private List<ManifestFile> newDeleteFilesAsManifests() {
}
if (cachedNewDeleteManifests.isEmpty()) {
+ Map<String, List<DeleteFile>> duplicateDVs = Maps.newHashMap();
+ List<DeleteFile> validDVs = Lists.newArrayList();
+ for (Map.Entry<String, List<DeleteFile>> entry :
dvsByReferencedFile.entrySet()) {
+ if (entry.getValue().size() > 1) {
+ duplicateDVs.put(entry.getKey(), entry.getValue());
+ } else {
+ validDVs.addAll(entry.getValue());
+ }
+ }
+
+ List<DeleteFile> mergedDVs =
+ duplicateDVs.isEmpty()
+ ? ImmutableList.of()
+ : DVUtil.mergeDVsAndWrite(
+ ops(), duplicateDVs, tableName,
ThreadPools.getDeleteWorkerPool());
+ // Prevent commiting duplicate V2 deletes by deduping them
Review Comment:
Yeah either here or in the above loop but change the log to indicate "Need
to merge" or "discovered" or something. I prefer in the existing loop because
I'm getting a bit wary of repeatedly looping over these structures (even if we
expect them to be small).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
