huaxingao commented on code in PR #15228:
URL: https://github.com/apache/iceberg/pull/15228#discussion_r2761726237
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -165,7 +165,7 @@ private static String convertToTypeString(Type type) {
}
return "timestamp";
case FIXED:
- case BINARY:
+ case BINARY, VARIANT:
Review Comment:
+1 to adding a short comment explaining this is a placeholder for HMS
display only, and that Iceberg reads the actual schema from metadata.json.
Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
