zeroshade commented on code in PR #8:
URL: https://github.com/apache/iceberg-terraform/pull/8#discussion_r2765756911
##########
internal/provider/provider.go:
##########
@@ -17,24 +17,43 @@ package provider
import (
"context"
+ "net/http"
+ "github.com/apache/iceberg-go/catalog"
+ "github.com/apache/iceberg-go/catalog/rest"
"github.com/hashicorp/terraform-plugin-framework/datasource"
"github.com/hashicorp/terraform-plugin-framework/provider"
"github.com/hashicorp/terraform-plugin-framework/provider/schema"
"github.com/hashicorp/terraform-plugin-framework/resource"
+ "github.com/hashicorp/terraform-plugin-framework/types"
)
var (
_ provider.Provider = &icebergProvider{}
)
// New is a helper function to simplify provider server and testing
implementation.
-func New() provider.Provider {
- return &icebergProvider{}
+func New() func() provider.Provider {
+ return func() provider.Provider {
+ return &icebergProvider{}
+ }
}
// icebergProvider is the provider implementation.
-type icebergProvider struct{}
+type icebergProvider struct {
+ catalogURI string
+ token string
+ warehouse string
+ headers map[string]string
+}
Review Comment:
should we allow a "type" parameter so that in the future we can support
non-rest catalogs with the same provider? (the default of "type" would be
"rest" and we can error on any other value for now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
