rambleraptor commented on code in PR #10: URL: https://github.com/apache/iceberg-terraform/pull/10#discussion_r2766430178
########## go.mod: ########## @@ -13,525 +13,184 @@ // See the License for the specific language governing permissions and // limitations under the License. -module github.com/apache/iceberg-terraform +module github.com/apache/terraform-provider-iceberg Review Comment: This is a whole can of worms. This was actually merged in earlier. Terraform is very opinionated on repo names. The repo name must match their pattern to be put on the registry. The binary name must match this pattern or Terraform won't pick it up properly. Even if you rename the file, you might get a runtime crash if the address name doesn't match! It's a pain. At the same time, Apache has strict repo naming guidelines that don't match Terraform's. The idea that @Fokko and I had was to keep the repo and then have Apache publish the provider on Apache's Terraform registry (built on JFrog) that hopefully won't have these limitations. This isn't an ideal situation. It's a change we need now and something we'll have to figure out again closer to release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
